Add support for subdomains and different scheme URLs for redirect #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
reviewed
Aug 2, 2018
| $input['default_login_redirection'] = strtolower( $input['default_login_redirection'] ); | ||
|
|
||
| // No change so no validation needed. | ||
| if ( $input['default_login_redirection'] === $old_options['default_login_redirection'] ) { |
There was a problem hiding this comment.
old_options will always be lower string?
joshcanhelp
force-pushed
the
fix-redirect-url-validation
branch
from
5df89fa
to
b9cbb6c
Compare
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
fix-redirect-url-validation
branch
from
b9cbb6c
to
d480cb2
Compare
joshcanhelp
force-pushed
the
fix-redirect-url-validation
branch
from
d480cb2
to
4afb8d8
Compare
joshcanhelp
force-pushed
the
fix-redirect-url-validation
branch
from
4afb8d8
to
a71aad6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows different schemes and subdomains to be used as the login redirection URL.
Closes #459.