Update new Application creation URLs #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
reviewed
Aug 2, 2018
| @@ -479,7 +479,7 @@ public static function create_client( $domain, $app_token, $name ) { | |||
| 'app_type' => 'regular_web', | |||
|
|
|||
| 'callbacks' => array( | |||
| $options->get_wp_auth0_url(), | |||
| site_url(), | |||
There was a problem hiding this comment.
Same URL except get_wp_auth0_url() has a URL param. Query strings aren't validated so I'm basically just removing the query string.
| @@ -492,8 +492,8 @@ public static function create_client( $domain, $app_token, $name ) { | |||
|
|
|||
| // A set of URLs that are valid to redirect to after logout from Auth0 | |||
| 'allowed_logout_urls' => array( | |||
| $options->get_logout_url(), | |||
There was a problem hiding this comment.
What happens if someone currently has logout set to logout url? I mean seems weird, just asking.
There was a problem hiding this comment.
Same as the other, just removing query strings because they're not validated
joshcanhelp
force-pushed
the
add-allowed-origins-to-setup
branch
from
28a2d20
to
100f9fe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing to URLs without a query string.