Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS and JS fields for new installs and ones an without existing value #634

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • New installs will not see the Custom CSS and Custom JS fields, only a message and link to upcoming documentation.
  • Installs without a value saved to these fields will see the same.
  • Installs with a value in either field will see a deprecation message.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.1.1

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 18, 2019
@codecov-io
Copy link

codecov-io commented Mar 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a78b427). Click here to learn what that means.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #634   +/-   ##
=========================================
  Coverage          ?   38.88%           
  Complexity        ?     1241           
=========================================
  Files             ?       51           
  Lines             ?     3811           
  Branches          ?        0           
=========================================
  Hits              ?     1482           
  Misses            ?     2329           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
lib/WP_Auth0_Options.php 72.72% <ø> (ø) 28 <0> (?)
lib/admin/WP_Auth0_Admin_Appearance.php 14.75% <94.11%> (ø) 19 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78b427...b4cd688. Read the comment docs.

@joshcanhelp joshcanhelp merged commit a66c28c into master Mar 20, 2019
@joshcanhelp joshcanhelp deleted the remove-css-js-settings branch March 20, 2019 13:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants