Deprecate WP_Auth0_LoginManager methods #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
previously approved these changes
Apr 1, 2019
joshcanhelp
force-pushed
the
deprecations-for-loginmanager
branch
from
d799bd2
to
a5a0e6d
Compare
damieng
approved these changes
Apr 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
============================================
+ Coverage 42.59% 43.04% +0.44%
+ Complexity 1221 1208 -13
============================================
Files 51 51
Lines 3742 3703 -39
============================================
Hits 1594 1594
+ Misses 2148 2109 -39
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR deprecates the following methods:
WP_Auth0_LoginManager::init()- Next major will moveadd_actioncalls to global functions.WP_Auth0_LoginManager::auth0_sso_footer()- No longer used.WP_Auth0_LoginManager:: auth0_singlelogout_footer()- No longer used.