Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations for API token handling #660

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

This PR deprecates the following methods + properties:

  • \WP_Auth0_Api_Abstract::$api_token - No longer used.
  • \WP_Auth0_Api_Abstract::$api_token_decoded - No longer used.
  • \WP_Auth0_Api_Abstract::decode_jwt() - No longer used.
  • \WP_Auth0_Api_Client_Credentials::$token_decoded - No longer used.
  • \WP_Auth0_Api_Client_Credentials::get_token_decoded() - No longer used.

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 31, 2019
@codecov-io
Copy link

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #660   +/-   ##
=========================================
  Coverage     42.12%   42.12%           
  Complexity     1238     1238           
=========================================
  Files            51       51           
  Lines          3779     3779           
=========================================
  Hits           1592     1592           
  Misses         2187     2187
Impacted Files Coverage Δ Complexity Δ
lib/api/WP_Auth0_Api_Client_Credentials.php 100% <ø> (ø) 10 <0> (ø) ⬇️
lib/api/WP_Auth0_Api_Abstract.php 98.78% <ø> (ø) 27 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab340...4e7dde3. Read the comment docs.

@joshcanhelp joshcanhelp merged commit bf1e3ba into master Apr 1, 2019
@joshcanhelp joshcanhelp deleted the deprecations-for-api-token-handling branch April 1, 2019 16:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants