Add auth0_lock_options filter #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
May 28, 2019
| @@ -57,7 +57,7 @@ public function tearDown() { | |||
| delete_transient( WP_Auth0_Api_Client_Credentials::TOKEN_TRANSIENT_KEY ); | |||
| delete_transient( WP_Auth0_Api_Client_Credentials::SCOPE_TRANSIENT_KEY ); | |||
|
|
|||
| remove_filter( 'wp_auth0_use_management_api_for_userinfo', '__return_false', 10 ); | |||
| remove_filter( 'auth0_use_management_api_for_userinfo', '__return_false', 10 ); | |||
There was a problem hiding this comment.
Filter has not been released so OK to change name
joshcanhelp
commented
May 28, 2019
| @@ -392,7 +392,7 @@ public function testThatLoginUserIsCalledWithIdTokenIfFilterIsSetToFalse() { | |||
| self::$opts->set( 'client_id', '__test_client_id__' ); | |||
| self::$opts->set( 'client_secret', '__test_client_secret__' ); | |||
| self::$opts->set( 'client_signing_algorithm', 'HS256' ); | |||
| add_filter( 'wp_auth0_use_management_api_for_userinfo', '__return_false', 10 ); | |||
| add_filter( 'auth0_use_management_api_for_userinfo', '__return_false', 10 ); | |||
There was a problem hiding this comment.
Filter has not been released so OK to change name
damieng
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
auth0_lock_optionsfilter to modify Lock options before usingwp_auth0_use_management_api_for_userinfotoauth0_use_management_api_for_userinfofor consistency.References
Docs PR to add new filter, change previous
Testing
Checklist