Fix sensitive field handling; add Basic settings tab validations #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jul 30, 2019
| @@ -7,7 +7,7 @@ | |||
| "php": "^5.3 || ^7.0" | |||
| }, | |||
| "require-dev": { | |||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.4.3", | |||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.5", | |||
There was a problem hiding this comment.
Development dependency
joshcanhelp
commented
Jul 30, 2019
| $input['client_id'] = sanitize_text_field( $input['client_id'] ); | ||
| $input['cache_expiration'] = absint( $input['cache_expiration'] ); | ||
|
|
||
| $input['allow_signup'] = ( isset( $input['allow_signup'] ) ? $input['allow_signup'] : 0 ); |
There was a problem hiding this comment.
Setting no longer exists
joshcanhelp
commented
Jul 30, 2019
| $input['client_id'] = sanitize_text_field( $input['client_id'] ); | ||
| $input['cache_expiration'] = absint( $input['cache_expiration'] ); | ||
|
|
||
| $input['allow_signup'] = ( isset( $input['allow_signup'] ) ? $input['allow_signup'] : 0 ); | ||
| $input['client_secret'] = sanitize_text_field( $input['client_secret'] ); | ||
| if ( __( '[REDACTED]', 'wp-auth0' ) === $input['client_secret'] ) { |
There was a problem hiding this comment.
If client secret is unchanged (set as [REDACTED] when saved), keep the previous one.
joshcanhelp
commented
Jul 30, 2019
| $input['client_secret_b64_encoded'] = ( isset( $input['client_secret_b64_encoded'] ) | ||
| ? $input['client_secret_b64_encoded'] == 1 | ||
| : false ); | ||
| if ( ! in_array( $input['client_signing_algorithm'], array( 'HS256', 'RS256' ) ) ) { |
There was a problem hiding this comment.
This is a radio button input with 2 choices.
damieng
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
passwordfield types (client secret and API token) triggering password managersNote to reviewers: bulk of the additions here are missing tests
References
Internal support request.
Testing
Please describe how this can be tested by reviewers. Tests must be added for new functionality and existing tests should complete without errors.
Checklist