Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WooCommerce hooks to global functions and remove init method #705

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jul 31, 2019

Changes

This is a potential (though unlikely) breaking change for developers!

  • BREAKING: Remove deprecated \WP_Auth0_WooCommerceOverrides:: init() method
  • BREAKING: Enforce WP_Auth0_WooCommerceOverrides constructor accepts a WP_Auth0_Options instance
  • Switch woocommerce_checkout_login_message hooked function from \WP_Auth0_WooCommerceOverrides::override_woocommerce_checkout_login_form() to new wp_auth0_filter_woocommerce_checkout_login_message()
  • Switch woocommerce_before_customer_login_form hooked function from \WP_Auth0_WooCommerceOverrides::override_woocommerce_login_form() to new wp_auth0_filter_woocommerce_before_customer_login_form()
  • Add a check for plugin readiness

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp marked this pull request as ready for review August 5, 2019 17:41
@joshcanhelp joshcanhelp requested a review from a team August 5, 2019 17:41
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please expand on how this is a breaking change? And, if that's true, can't the current existing methods call the new ones to keep compatibility without breaking anything?

@joshcanhelp
Copy link
Contributor Author

@lbalmaceda - I highlighted the breaking changes in the description. This is on the road to a major so breaking is expected. The removed method was marked deprecated and very unlikely to be used. There will be a number of 4.0.0 tagged breaking changes coming.

@lbalmaceda
Copy link
Contributor

@joshcanhelp Sorry I missed the milestone.

@joshcanhelp joshcanhelp merged commit 63c15af into master Aug 7, 2019
@joshcanhelp joshcanhelp deleted the update-woocommerce-class branch August 7, 2019 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants