Fix widget gravatar and language settings #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Jul 31, 2019
| @@ -113,9 +118,14 @@ protected function build_settings( $settings ) { | |||
|
|
|||
| $options_obj['socialButtonStyle'] = 'big'; | |||
|
|
|||
| if ( isset( $settings['gravatar'] ) && empty( $settings['gravatar'] ) ) { | |||
| if ( isset( $settings['gravatar'] ) && '' !== $settings['gravatar'] && empty( $settings['gravatar'] ) ) { | |||
There was a problem hiding this comment.
empty is already "". If you check for !="" and empty at the same time, this will never be called! What is going on here? 🤕
'' !== $settings['gravatar'] && empty( $settings['gravatar'] )
There was a problem hiding this comment.
It's a little wonky because it has a number of settings arrays that override each other with successive option building.
'' is an empty string (in this case, means use the default), isset() is whether that key exists or not (avoids Undefined index errors), and empty() checks for 0, null, false, etc.
| $options_obj['avatar'] = null; | ||
| } | ||
|
|
||
| if ( ! empty( $settings['gravatar'] ) ) { |
There was a problem hiding this comment.
you check for empty but not for isset, why ?
There was a problem hiding this comment.
empty() covers the isset() case. Means "no truth-y value to use".
lbalmaceda
approved these changes
Aug 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note to reviewers: PO, MO, and POT files can be ignored.