Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check state in specific global based on callback type #708

Merged

Conversation

@joshcanhelp
Copy link
Member

commented Aug 1, 2019

Changes

Fix state checking to look in the correct global ($_GET for auth code, $_POST for implicit) instead of query var or $_REQUEST.

References

Reverts #707

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed
@joshcanhelp joshcanhelp added this to the 3.11.1 milestone Aug 1, 2019
@joshcanhelp joshcanhelp requested a review from damieng Aug 1, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review Aug 1, 2019
@joshcanhelp joshcanhelp requested review from and removed request for damieng Aug 1, 2019
@joshcanhelp joshcanhelp merged commit 41bcbcd into wordpress-org-plugin Aug 2, 2019
6 checks passed
6 checks passed
ci/circleci: php_5 Your tests passed on CircleCI!
Details
ci/circleci: php_7 Your tests passed on CircleCI!
Details
ci/circleci: snyk Your tests passed on CircleCI!
Details
codecov/changes Unable to determine changes, no report found at pull request base.
Details
codecov/patch 80% of diff hit (target 80%)
Details
codecov/project No report found to compare against
Details
@joshcanhelp joshcanhelp deleted the fix-state-handling-to-specific-global branch Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.