Update auth params method to add filters #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Aug 13, 2019
| @@ -46,49 +46,6 @@ function( $default_scope, $context ) { | |||
| $this->assertEquals( 'openid email profile auth0', $scope ); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Split out into different tests in the class added below 👇
joshcanhelp
commented
Aug 13, 2019
| ] | ||
| ) | ||
| ); | ||
| if ( empty( $filtered_params['state'] ) ) { |
There was a problem hiding this comment.
This allows backwards-compat with anyone generating their own state.
There was a problem hiding this comment.
nonce can be customized?
There was a problem hiding this comment.
State-level unique value can be (default generated state would always be the same value if not). Use case here is for adding values, though.
lbalmaceda
reviewed
Aug 15, 2019
|
|
||
| if ( $is_implicit ) { | ||
| $params['nonce'] = $nonce; | ||
| $params['response_mode'] = 'form_post'; |
There was a problem hiding this comment.
Moved up to be more explicit
| ] | ||
| ) | ||
| ); | ||
| if ( empty( $filtered_params['state'] ) ) { |
There was a problem hiding this comment.
nonce can be customized?
|
@lbalmaceda - Not urgent but ping for you here :) |
lbalmaceda
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
auth0_authorize_url_paramsbefore state is generated and decodedauth0_authorize_stateto modify state contents before decodingTesting
Checklist