Add wpa0_user_data filter before creating WP_User #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horike37
changed the title
joshcanhelp
suggested changes
Aug 14, 2019
lib/WP_Auth0_Users.php
Outdated
| @@ -84,6 +84,8 @@ public static function create_user( $userinfo, $role = null ) { | |||
| 'description' => $description, | |||
| ]; | |||
|
|
|||
| $user_data = apply_filters( 'wpa0_user_data', $user_data, $userinfo, $firstname, $lastname ); | |||
There was a problem hiding this comment.
The naming convention for hooks isn't 100% consistent but we've been using auth0_ as the namespace for new ones. Can you update the filter name to auth0_create_user_data to add that namespace and make this more explicit?
Also, the $firstname and $lastname parameters are not necessary since their values are already in the array.
There was a problem hiding this comment.
@joshcanhelp
Thank you for review 👍 Happy to hear that this PR will be merged 😄
I just updated all what you pointed. Please check it again.
joshcanhelp
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add filter
auth0_create_user_datato allow customizing user data before creating WP_User because I would like to separatedisplay_namefromusername. The current implementation hardcodes the WordPressuser_loginanddisplay_nameto come from the Auth0username. However, in many cases, those are separated based on naming style in Japan.References
There is no reference. only this PR.
Testing
Checklist