Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused setup wizard classes, methods, and templates #719

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Remove unused setup wizard classes, methods, and templates #719

merged 1 commit into from
Aug 16, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Aug 15, 2019 •
edited

Changes

This is a potential (though unlikely) breaking change for developers!

  • Remove unused and deprecated WP_Auth0_InitialSetup_Migration class
  • Remove unused and deprecated WP_Auth0_InitialSetup_Rules class
  • Remove unused and deprecated WP_Auth0_InitialSetup_Signup class
  • Remove unused and deprecated WP_Auth0_InitialSetup::admin_enqueue() method
  • Remove unused and deprecated WP_Auth0_InitialSetup::notify_setup() method
  • Remove unused and deprecated WP_Auth0_InitialSetup_Connections::update_connection() method
  • Remove unused and deprecated WP_Auth0_InitialSetup_Connections::toggle_db() method
  • Remove unused and deprecated WP_Auth0_InitialSetup_Connections::toggle_social() method

Note to reviewers: As usual, POT, PO, and MO files can be ignored, just removing now-unused translation strings.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Aug 15, 2019
@joshcanhelp joshcanhelp requested a review from a team August 15, 2019 21:12
lbalmaceda
lbalmaceda approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit 09c196d into master Aug 16, 2019
@joshcanhelp joshcanhelp deleted the remove-unused-setup-wizard-parts branch August 16, 2019 00:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @lbalmaceda