Remove all unused and deprecated advanced setting functionality #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Aug 21, 2019
| @@ -530,13 +401,15 @@ public function render_auth0_server_domain( $args = [] ) { | |||
| ); | |||
| } | |||
|
|
|||
| public function auth0_rotate_migration_token() { | |||
There was a problem hiding this comment.
Moved to wp_auth0_ajax_rotate_migration_token() above
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a potential (though unlikely) breaking change for developers!
wp_auth0_ajax_rotate_migration_token()function hooked towp_ajax_auth0_rotate_migration_tokento handle migration token rotation action; added admin auth check.wp_auth0_generate_token()to handle token generation.WP_Auth0_Admin_Advanced::ADVANCED_DESCRIPTIONconstantWP_Auth0_Admin_Advanced::render_connections()methodWP_Auth0_Admin_Advanced::render_custom_cdn_url()methodWP_Auth0_Admin_Advanced::render_cdn_url()methodWP_Auth0_Admin_Advanced::render_link_auth0_users()methodWP_Auth0_Admin_Advanced::render_extra_conf()methodWP_Auth0_Admin_Advanced::link_accounts_validation()methodWP_Auth0_Admin_Advanced::render_ip_range_check()methodWP_Auth0_Admin_Advanced::render_ip_ranges()methodWP_Auth0_Admin_Advanced::render_social_twitter_key()methodWP_Auth0_Admin_Advanced::render_social_twitter_secret()methodWP_Auth0_Admin_Advanced::render_social_facebook_key()methodWP_Auth0_Admin_Advanced::render_social_facebook_secret()methodWP_Auth0_Admin_Advanced::render_passwordless_enabled()methodWP_Auth0_Admin_Advanced::render_passwordless_method()methodWP_Auth0_Admin_Advanced::render_metrics()methodWP_Auth0_Admin_Advanced::render_advanced_description()methodWP_Auth0_Admin_Advanced::connections_validation()methodWP_Auth0_Admin_Advanced::generate_token()method (usingwp_auth0_generate_token()instead)WP_Auth0_Admin_Advanced::auth0_rotate_migration_token()method (usingwp_auth0_ajax_rotate_migration_token()instead)Note to reviewers: As usual, POT, PO, and MO files can be ignored, just removing now-unused translation strings.
Testing
Checklist