Remove appearance settings #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Aug 30, 2019
| @@ -40,20 +40,6 @@ public function install_db( $version_to_install = null ) { | |||
| $this->migrate_users_data(); | |||
| } | |||
|
|
|||
| // Plugin version < 3.2.3 | |||
There was a problem hiding this comment.
This conversion is problematic and ~0 tenants reporting a version this low.
joshcanhelp
commented
Aug 30, 2019
| $extra_conf = []; | ||
| } | ||
|
|
||
| $language = $options->get( 'language' ); |
There was a problem hiding this comment.
Merge existing language settings into general "extra_conf" setting.
lbalmaceda
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes a number of settings and their associated methods.
If you are currently using the custom JS or CSS fields in the main plugin settings or widget forms, their content will no longer be output. Please use the
wp_enqueue_styleandwp_enqueue_scripthooks to load CSS and JS on the appropriate page.If you are using a different language or language dictionary plugin settings, these fields have been removed but their values will be merged into the "Extra Settings" JSON when the plugin updates. Site administrators should backup these values before updating and check that the merge happened correctly after the update. Individual widgets using the language dictionary field have not been changed.
WP_Auth0_Lock10_Options:: get_custom_css()methodWP_Auth0_Lock10_Options:: get_custom_js()methodWP_Auth0_Admin_Appearance::APPEARANCE_DESCRIPTIONconstantWP_Auth0_Admin_Appearance::render_social_big_buttons()methodWP_Auth0_Admin_Appearance::render_custom_css()methodWP_Auth0_Admin_Appearance::render_custom_js()methodWP_Auth0_Admin_Appearance::render_language()methodWP_Auth0_Admin_Appearance::render_language_dictionary()methodWP_Auth0_Admin_Appearance::render_appearance_description()methodNote for reviewers: As always, ignore the PO, MO, and POT changes here.
Testing