Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated WP_Auth0_Api_Client methods #725

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 26, 2019

Changes

This is a potential breaking change for developers!

Remove all deprecated WP_Auth0_Api_Client methods:

  • get_info_headers()
  • get_token()
  • get_client_token()
  • get_user_info()
  • get_user()
  • get_client()
  • update_client()
  • create_rule()
  • delete_rule()
  • get_connection()
  • update_user()
  • GetConsentScopestoShow()
  • update_guardian()
  • ro()
  • validate_user_token()
  • search_users()
  • resend_verification_email()
  • create_user()
  • search_clients()
  • get_current_user()
  • delete_connection()
  • delete_user_mfa()
  • change_password()
  • link_users()

Note to reviewers: All additions in the changeset are docblocks.

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Sep 26, 2019
@joshcanhelp joshcanhelp requested a review from a team September 27, 2019 00:00
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of "helper" methods that are public. I suggest you check whether they require to be public or you can lower the visibility, so that in the future you could make changes to them without breaking anyone or needing to deprecate methods.

@joshcanhelp
Copy link
Contributor Author

@lbalmaceda - Good point. I started down the road of improving this class but it made for a very confusing diff so I wanted to clean it up first.

@joshcanhelp joshcanhelp merged commit cea4649 into master Sep 27, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-api-client branch September 27, 2019 18:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants