Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/Adding Brazilian Portuguese translations #729

Merged
merged 29 commits into from
Oct 10, 2019
Merged

feature/Adding Brazilian Portuguese translations #729

merged 29 commits into from
Oct 10, 2019

Conversation

niugait
Copy link
Contributor

@niugait niugait commented Sep 27, 2019

Changes

Added Brazilian Portuguese translations

  • Updated from latest version (2019-09-26)

@joshcanhelp
Copy link
Contributor

@niugait - Thank you for doing this (again)! I'll submit this to one of the engineers on our team that speaks Portuguese for review.

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Sep 27, 2019
@niugait
Copy link
Contributor Author

niugait commented Sep 27, 2019

@joshcanhelp No problem, let me know if you need anything else.

luisrudge
luisrudge previously requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@luisrudge luisrudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉 I made some suggestions of fixes we need it before merging it. Let me know if you have any questions.

languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
languages/wp-auth0-pt_BR.po Outdated Show resolved Hide resolved
@joshcanhelp
Copy link
Contributor

@niugait - Can you apply all the suggestions from Luis here? I tried to commit them but it's telling me I don't have the permissions to do so. Thank you!

@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
608a4f7 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait niugait requested a review from a team October 10, 2019 21:47
niugait and others added 19 commits October 10, 2019 18:47
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
0e63a13 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
78c1410 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
87f4c52 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
1601f2b 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
be6e62a 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
cd09d7a 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
d57f334 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
4a15f7b 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
c1bb716 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
470207f 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
ff6ba9a 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
975eaf0 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
ac004b2 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
dd0f942 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
f66b08d 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
e781915 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
9e52fe0 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
20f1992 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
06cc2ad 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
niugait and others added 5 commits October 10, 2019 18:58
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
4c251a3 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
135b48d 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Apply suggestions from code review
ebf0024 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
c0620ff 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait @luisrudge
Update languages/wp-auth0-pt_BR.po
1a59fdd 
Co-Authored-By: Luís Rudge <luis@luisrudge.net>
@niugait
Copy link
Contributor Author

niugait commented Oct 10, 2019

@joshcanhelp Done!

@joshcanhelp joshcanhelp dismissed luisrudge’s stale review October 10, 2019 22:08

Suggestions applied. Thanks Luis!!

@joshcanhelp
Copy link
Contributor

Formatting checks find no errors and tests pass:

Runtime:       PHP 7.2.18 with Xdebug 2.6.0
Configuration: /Users/josh-cunningham/Sites/wp-auth0/wp-content/plugins/auth0/phpunit.xml.dist

...............................................................  63 / 340 ( 18%)
............................................................... 126 / 340 ( 37%)
............................................................... 189 / 340 ( 55%)
............................................................... 252 / 340 ( 74%)
............................................................... 315 / 340 ( 92%)
.........................                                       340 / 340 (100%)

Time: 1.29 minutes, Memory: 54.00MB

OK (340 tests, 1384 assertions)

@joshcanhelp joshcanhelp merged commit 8cb40b5 into auth0:master Oct 10, 2019
@joshcanhelp
Copy link
Contributor

Muito obrigado @niugait!

@niugait
Copy link
Contributor Author

niugait commented Oct 10, 2019

You're welcome @joshcanhelp ! If you guys need some extra tweaks on this, just let me know.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

@luisrudge luisrudge luisrudge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niugait @joshcanhelp @luisrudge @navesd