Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WP_Auth0_EditProfile #743

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Remove WP_Auth0_EditProfile #743

merged 1 commit into from
Dec 6, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Move WP_Auth0_EditProfile::admin_enqueue_scripts() to wp_auth0_profile_enqueue_scripts()
  • Remove WP_Auth0_EditProfile

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 6, 2019
joshcanhelp
joshcanhelp commented Dec 6, 2019
View reviewed changes
WP_Auth0.php
@@ -504,6 +501,44 @@ public static function get_plugin_dir_url() {
* Core WP hooks
*/

function wp_auth0_profile_enqueue_scripts() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as WP_Auth0_EditProfile::admin_enqueue_scripts() method removed below.

@joshcanhelp joshcanhelp marked this pull request as ready for review December 6, 2019 00:37
@joshcanhelp joshcanhelp requested a review from a team December 6, 2019 00:37
@joshcanhelp joshcanhelp merged commit cc96137 into master Dec 6, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-profile-actions branch December 6, 2019 03:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @damieng