Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated from User and Change Password #750

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Remove deprecated from User and Change Password #750

merged 2 commits into from
Dec 16, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 13, 2019 •
edited

Changes

  • Remove $role parameter from WP_Auth0_Users::create_user()
  • Remove WP_Auth0_Profile_Change_Password::init()

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 13, 2019
@joshcanhelp joshcanhelp changed the title Remove deprecated from user and profile Remove deprecated from User and Change Password Dec 13, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review December 13, 2019 22:36
@joshcanhelp joshcanhelp requested a review from a team December 13, 2019 22:36
@joshcanhelp joshcanhelp merged commit 42268f4 into master Dec 16, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-from-user-and-profile branch December 16, 2019 17:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @stevehobbsdev