Patch samesite for implicit #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jan 13, 2020
lib/WP_Auth0_Nonce_Handler.php
Outdated
| @@ -166,13 +179,94 @@ public function generate_unique( $bytes = 32 ) { | |||
| * @return bool | |||
| */ | |||
| protected function handle_cookie( $cookie_name, $cookie_value, $cookie_exp ) { | |||
| $illegal_chars = ",; \t\r\n\013\014"; | |||
| if ( strpbrk( $cookie_name, $illegal_chars ) != null ) { | |||
There was a problem hiding this comment.
This check just clues the administrator into an issue via the plugin error log if, for some reason, they're doing something wrong with customer state/nonce values. With one of these characters in place, the validation would be silently failing so this is not a breaking change.
joshcanhelp
commented
Jan 13, 2020
| @@ -39,6 +39,14 @@ class WP_Auth0_Nonce_Handler { | |||
| */ | |||
There was a problem hiding this comment.
The pattern for the additions to this file was pulled from the PHP SDK:
https://github.com/auth0/auth0-PHP/pull/395/files#diff-edb92fb2369f39801bab7466d95cbc1c
joshcanhelp
force-pushed
the
patch-samesite-for-implicit
branch
from
435951c
to
17e04df
Compare
joshcanhelp
force-pushed
the
patch-samesite-for-implicit
branch
from
17e04df
to
9cc45f6
Compare
jimmyjames
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Important note for sites using the implicit flow: The upcoming changes to SameSite handling in multiple browsers will require sites using the Implicit Login Flow setting to also be served on a secure channel (callback URL using "https"). This setting will be removed in the upcoming major version (please comment below if you have an important use case that this will affect).
References
Web.dev: SameSite cookies explained
Testing
Checklist