Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error_log calls and add auth0_insert_error action #763

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Remove error_log calls and add auth0_insert_error action #763

merged 2 commits into from
Jan 27, 2020

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Remove all calls to PHP core error_log
  • Add auth0_insert_error action to allow additional error handling

Testing

  • This change adds unit test coverage
  • This change has been tested on PHP 7.1 and WP 5.3.2

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 25, 2020
@joshcanhelp joshcanhelp marked this pull request as ready for review January 25, 2020 01:16
@joshcanhelp joshcanhelp requested a review from a team January 25, 2020 01:16
@joshcanhelp joshcanhelp merged commit 863dd5a into master Jan 27, 2020
@joshcanhelp joshcanhelp deleted the change-error-handling branch January 27, 2020 15:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @stevehobbsdev