Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to break cache if RS256 ID token kid is not found #770

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jan 30, 2020

Changes

Add WP_Auth0_JwksFetcher->getKey() for use in WP_Auth0_AsymmetricVerifier to fetch a new JWKS when an incoming token KID is not found in the cached set. This library doesn't accept arbitrary requests that involve token validation and the endpoint that validates tokens is protected by a state parameter so there is not much of a risk of invalid kid spamming.

References

SDK-1224

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3.2 and PHP 7.1

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp requested a review from a team January 30, 2020 21:29
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 30, 2020
davidpatrick
davidpatrick previously approved these changes Jan 31, 2020
@joshcanhelp joshcanhelp merged commit d68140a into master Jan 31, 2020
@joshcanhelp joshcanhelp deleted the add-signing-key-rotation branch January 31, 2020 21:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants