Update Feature settings validation and defaults #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jan 31, 2020
| protected function sanitize_switch_val( $val ) { | ||
| return in_array( $val, [ 1, '1', true ] ) ? true : false; | ||
| return in_array( $val, [ 1, '1', true ], true ) ? true : false; |
There was a problem hiding this comment.
This makes the check strict so $val is not casted in any way.
lbalmaceda
reviewed
Jan 31, 2020
joshcanhelp
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
WP guidance on sanitization and escaping
Testing