Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Basic settings validation and defaults #775

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Update Basic settings validation and defaults #775

merged 1 commit into from
Feb 3, 2020

Conversation

joshcanhelp
Copy link
Contributor

Description

  • Normalize settings validation for the Basic tab
  • Normalize defaults for the Basic tab
  • Remove WP_Auth0_Admin_Basic->wle_validation()

References

WP guidance on sanitization and escaping

Testing

  • This change improves test coverage for new/changed/fixed functionality

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 31, 2020
@joshcanhelp joshcanhelp force-pushed the update-basic-settings-validation branch from 054e833 to 9f87d03 Compare January 31, 2020 21:37
@joshcanhelp joshcanhelp marked this pull request as ready for review January 31, 2020 21:39
@joshcanhelp joshcanhelp requested a review from a team January 31, 2020 21:39
@joshcanhelp joshcanhelp mentioned this pull request Jan 31, 2020
Merged
1 task
@joshcanhelp joshcanhelp merged commit 3054647 into master Feb 3, 2020
@joshcanhelp joshcanhelp deleted the update-basic-settings-validation branch February 3, 2020 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @damieng