Remove migration JWT JTI check #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the base branch from
master
to
add-settings-validation-to-import
joshcanhelp
changed the base branch from
add-settings-validation-to-import
to
master
joshcanhelp
changed the base branch from
master
to
add-settings-validation-to-import
joshcanhelp
force-pushed
the
remove-migration-jwt-jti
branch
from
d135ec2
to
3de8626
Compare
joshcanhelp
changed the base branch from
add-settings-validation-to-import
to
master
jimmyjames
previously approved these changes
Feb 6, 2020
joshcanhelp
force-pushed
the
remove-migration-jwt-jti
branch
from
3de8626
to
92acd4b
Compare
jimmyjames
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove JWT JTI check for migration routes. Token is checked against stored value so token can be opaque. This will only affect sites that generated their own migration token as a JWT and stored a different token in the migration route than in the WordPress site (which would be a really odd thing to do).
Testing
Checklist
master