Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential infinite loop on email update #802

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fix potential infinite loop on email update #802

merged 2 commits into from
Oct 1, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 24, 2020 •
edited

Switch remove_action() and subsequent add_action() call to remove/add the function that calls this method, rather than the method itself.

Fixes #800.
Waiting on #803 for CI fixes

@joshcanhelp joshcanhelp requested a review from a team September 24, 2020 22:40
@joshcanhelp joshcanhelp marked this pull request as draft October 1, 2020 19:16
@joshcanhelp joshcanhelp marked this pull request as ready for review October 1, 2020 21:55
@lbalmaceda lbalmaceda merged commit 93c951a into master Oct 1, 2020
@lbalmaceda lbalmaceda deleted the fix-profile-update-loop branch October 1, 2020 22:04
@joshcanhelp joshcanhelp added this to the 4.1.1 milestone Oct 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.

Possible infinite loop in profile_update hook
2 participants
@joshcanhelp @lbalmaceda