Support PHP 8.0 #814
Merged
Support PHP 8.0 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is throwing an erroneous codecov failure for unknown reasons. It is detecting code changes in files that weren't changed. Once this is reviewed I'm going to force merge this and hopefully that will resolve the coverage diff issues. |
lbalmaceda
suggested changes
Jan 27, 2021
|
@lbalmaceda Thanks for your feedback! I addressed your questions and committed a few changes, whenever you get time to re-review. Thanks! |
cocojoe
reviewed
Feb 2, 2021
lbalmaceda
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes necessary to improve compatibility with PHP 8, updates our CircleCI configuration, updates our unit test configuration to reflect and target the minimum PHP and WordPress versions we support, and fixes a number of issues with our documentation around parameter types (they remain functionally unchanged; our docblocks were just incorrect in their existing usage.)
To test these changes locally you will need a local MySQL installation. From the root directory run
bin/install-wp-tests.shwhich will output the proper command syntax. Provide your local database details. For the target WordPress version, specify5.6for this PR. After the command finishes, runcomposer checkupto run the test suite.