Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): use boolean instead of integer #2776

Merged
merged 4 commits into from Jan 12, 2022

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Jan 7, 2022

This fixes an issue where an integer is used instead of a boolean.

Fixes #2775.

This fixes an issue where an integer is used instead of a boolean.
@authelia
Copy link

authelia bot commented Jan 7, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:fix-sql-banned-arg-type
  • docker pull ghcr.io/authelia/authelia:fix-sql-banned-arg-type

@clems4ever clems4ever self-requested a review January 11, 2022 22:11
Copy link
Member

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #2776 (fc95094) into master (03caeba) will increase coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
+ Coverage   67.46%   68.49%   +1.02%     
==========================================
  Files         215      215              
  Lines       11205    11205              
  Branches      436      436              
==========================================
+ Hits         7560     7675     +115     
+ Misses       3177     3069     -108     
+ Partials      468      461       -7     
Flag Coverage Δ
backend 67.56% <ø> (+0.04%) ⬆️
frontend 70.84% <ø> (+5.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/services/OneTimePassword.ts 91.66% <0.00%> (-8.34%) ⬇️
...LoginPortal/SecondFactor/OneTimePasswordMethod.tsx 93.97% <0.00%> (+1.20%) ⬆️
web/src/views/LoginPortal/LoginPortal.tsx 92.08% <0.00%> (+2.15%) ⬆️
web/src/views/LoginPortal/SecondFactor/OTPDial.tsx 93.75% <0.00%> (+3.12%) ⬆️
...iews/LoginPortal/SecondFactor/SecondFactorForm.tsx 74.02% <0.00%> (+5.19%) ⬆️
...views/LoginPortal/SecondFactor/MethodContainer.tsx 89.47% <0.00%> (+6.57%) ⬆️
web/src/App.tsx 91.11% <0.00%> (+6.66%) ⬆️
web/src/components/FailureIcon.tsx 100.00% <0.00%> (+14.28%) ⬆️
...LoginPortal/SecondFactor/MethodSelectionDialog.tsx 87.50% <0.00%> (+15.00%) ⬆️
web/src/views/LoginPortal/SignOut/SignOut.tsx 85.41% <0.00%> (+18.75%) ⬆️
... and 9 more

@james-d-elliott james-d-elliott merged commit d103585 into master Jan 12, 2022
@james-d-elliott james-d-elliott deleted the fix-sql-banned-arg-type branch January 12, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgresSQL error
2 participants