Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): allow rfc4918 http verbs in acl #2988

Merged
merged 7 commits into from Apr 1, 2022

Conversation

james-d-elliott
Copy link
Member

This allows the HTTP Method verbs from RFC4918 to be used. See https://datatracker.ietf.org/doc/html/rfc4918 for more information.

Closes #2923

This allows the HTTP Method verbs from RFC4918 to be used. See https://datatracker.ietf.org/doc/html/rfc4918 for more information.
@james-d-elliott james-d-elliott added this to the v4.35.0 milestone Mar 9, 2022
@authelia
Copy link

authelia bot commented Mar 9, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-rfc2518-verbs
  • docker pull ghcr.io/authelia/authelia:feat-rfc2518-verbs

@james-d-elliott james-d-elliott added the status/ready Is ready to try/merge label Mar 14, 2022
api/openapi.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2988 (0ed35cf) into master (c3faa38) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
+ Coverage   62.91%   62.94%   +0.03%     
==========================================
  Files         224      224              
  Lines       11786    11786              
  Branches      352      352              
==========================================
+ Hits         7415     7419       +4     
+ Misses       3867     3863       -4     
  Partials      504      504              
Flag Coverage Δ
backend 67.51% <100.00%> (+0.03%) ⬆️
frontend 37.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/configuration/validator/access_control.go 100.00% <100.00%> (ø)
internal/commands/storage_run.go 57.46% <0.00%> (+0.40%) ⬆️
internal/authorization/util.go 94.40% <0.00%> (+1.39%) ⬆️

Copy link
Member

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit b2d35d8 into master Apr 1, 2022
@james-d-elliott james-d-elliott deleted the feat-rfc2518-verbs branch April 1, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Is ready to try/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow custom HTTP methods
3 participants