Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: envoy support #3793

Merged
merged 20 commits into from Oct 1, 2022
Merged

feat: envoy support #3793

merged 20 commits into from Oct 1, 2022

Conversation

james-d-elliott
Copy link
Member

This effectively adds support for envoy. Docs to come.

@authelia
Copy link

authelia bot commented Aug 6, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-envoy
  • docker pull ghcr.io/authelia/authelia:feat-envoy

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #3793 (b6a9ff9) into master (18a2bde) will increase coverage by 0.09%.
The diff coverage is 83.01%.

❗ Current head b6a9ff9 differs from pull request most recent head 19a8cdb. Consider uploading reports for the commit 19a8cdb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3793      +/-   ##
==========================================
+ Coverage   69.17%   69.27%   +0.09%     
==========================================
  Files         258      258              
  Lines       16228    16252      +24     
  Branches      434      435       +1     
==========================================
+ Hits        11226    11258      +32     
+ Misses       4313     4306       -7     
+ Partials      689      688       -1     
Flag Coverage Δ
backend 70.04% <93.47%> (+0.09%) ⬆️
frontend 62.63% <14.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/oidc/types.go 100.00% <ø> (ø)
web/src/services/Consent.ts 20.00% <0.00%> (ø)
.../src/views/LoginPortal/ConsentView/ConsentView.tsx 20.18% <16.66%> (-0.92%) ⬇️
internal/handlers/handler_oidc_consent.go 31.75% <25.00%> (ø)
...nal/handlers/handler_oidc_authorization_consent.go 40.63% <100.00%> (ø)
internal/handlers/handler_verify.go 76.79% <100.00%> (+0.65%) ⬆️
internal/handlers/util.go 100.00% <100.00%> (ø)
internal/middlewares/authelia_context.go 74.13% <100.00%> (+0.45%) ⬆️
internal/server/handlers.go 93.10% <100.00%> (+0.07%) ⬆️
... and 1 more

@james-d-elliott james-d-elliott marked this pull request as ready for review August 6, 2022 02:29
@netlify
Copy link

netlify bot commented Aug 6, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 8a4e789
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63381d89131d760009e376d5
😎 Deploy Preview https://deploy-preview-3793--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work with this!

@james-d-elliott
Copy link
Member Author

LGTM, great work with this!

Likewise, we knocked this out so damn quickly. Really helps to have a few sets of eyes.

@james-d-elliott james-d-elliott added this to the v4.37.0 milestone Sep 13, 2022
@james-d-elliott james-d-elliott added the status/ready Is ready to try/merge label Sep 16, 2022
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we left a couple debug log lines in since we were trying to fix this.

internal/handlers/handler_verify.go Outdated Show resolved Hide resolved
internal/utils/url.go Outdated Show resolved Hide resolved
Co-authored-by: Amir Zarrinkafsh <nightah@me.com>
@james-d-elliott james-d-elliott added the priority/4/normal Normal priority items label Sep 26, 2022
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/4/normal Normal priority items status/ready Is ready to try/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants