feat(server): customizable authz endpoints #4296

james-d-elliott · 2022-10-30T01:11:43Z

This allows users to customize the authz endpoints.

Closes #2753, Fixes #3716

authelia · 2022-10-30T01:11:46Z

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

docker pull authelia/authelia:feat-authz-custom
docker pull ghcr.io/authelia/authelia:feat-authz-custom

netlify · 2022-10-30T01:12:27Z

✅ Deploy Preview for authelia-staging ready!

Name	Link
🔨 Latest commit	`59ed3ed`
🔍 Latest deploy log	https://app.netlify.com/sites/authelia-staging/deploys/63d0d5401d3c4f000924ea89
😎 Deploy Preview	https://deploy-preview-4296--authelia-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This allows users to customize the authz endpoints.

codecov · 2023-01-03T06:24:30Z

Codecov Report

Merging #4296 (561c64d) into master (78064de) will increase coverage by 0.23%.
The diff coverage is 73.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4296      +/-   ##
==========================================
+ Coverage   67.40%   67.63%   +0.23%     
==========================================
  Files         271      281      +10     
  Lines       19811    20647     +836     
  Branches      443      443              
==========================================
+ Hits        13353    13964     +611     
- Misses       5678     5872     +194     
- Partials      780      811      +31

Flag	Coverage Δ
backend	`67.99% <73.34%> (+0.23%)`	⬆️
frontend	`63.15% <ø> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/commands/root.go	`40.57% <0.00%> (ø)`
internal/handlers/handler_oidc_consent.go	`30.23% <0.00%> (-1.92%)`	⬇️
internal/handlers/handler_register_webauthn.go	`0.00% <0.00%> (ø)`
internal/handlers/handler_sign_webauthn.go	`0.00% <0.00%> (ø)`
internal/handlers/util.go	`64.70% <ø> (-9.77%)`	⬇️
internal/handlers/response.go	`43.10% <6.66%> (-1.95%)`	⬇️
internal/server/template.go	`44.07% <12.50%> (+0.05%)`	⬆️
internal/handlers/handler_oidc_authorization.go	`37.50% <30.00%> (-3.62%)`	⬇️
internal/handlers/handler_sign_totp.go	`37.97% <38.46%> (-1.16%)`	⬇️
internal/handlers/handler_state.go	`54.54% <38.46%> (-20.46%)`	⬇️
... and 47 more

internal/handlers/handler_authz_impl_legacy_test.go

internal/handlers/handler_authz_util.go

nightah

Great work so far, I've submitted my first pass review.

I suspect with some of those changes from require to assert and using the suite method that some of the imports may no longer be required, the linter should hopefully pick this up on the next commit.

docs/content/en/integration/kubernetes/traefik-ingress.md

docs/content/en/integration/proxies/caddy.md

docs/content/en/integration/proxies/traefik.md

internal/handlers/handler_user_info_test.go

internal/middlewares/authelia_context.go

nightah · 2023-01-23T03:09:58Z

internal/suites/suite_pathprefix_test.go

@@ -14,6 +14,10 @@ func NewPathPrefixSuite() *PathPrefixSuite {
 	return &PathPrefixSuite{RodSuite: new(RodSuite)}
 }

+func (s *PathPrefixSuite) TestCheckEnv() {


I suspect this file should actually change after we've merged in the suite environment changes first?

Yep, makes sense. Did they look good to you?

internal/utils/bytes.go

internal/suites/const.go

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

internal/handlers/handler_user_info_test.go

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

# Conflicts: # internal/suites/const.go # internal/suites/example/compose/authelia/docker-compose.backend.dev.yml # internal/suites/example/compose/caddy/Caddyfile # internal/suites/example/compose/haproxy/haproxy.cfg # internal/suites/scenario_multiple_cookie_domain_test.go # internal/suites/scenario_one_factor_test.go # internal/suites/utils.go

nightah

LGTM.

james-d-elliott force-pushed the feat-authz-custom branch 4 times, most recently from b41f249 to 6657375 Compare October 30, 2022 06:24

feat(sever): customizable authz endpoints

2ec0686

This allows users to customize the authz endpoints.

james-d-elliott force-pushed the feat-authz-custom branch from 6657375 to 2ec0686 Compare October 30, 2022 22:33

james-d-elliott added 8 commits November 12, 2022 21:21

Merge remote tracking branch origin/master into feat-authz-custom

b866c4f

docs: misc updates

cdef19f

Merge remote-tracking branch 'origin/master' into feat-authz-custom

43a5a63

Merge remote-tracking branch 'origin/master' into feat-authz-custom

18845d9

fix: ext authz method implemenation

bfb98ec

Merge branch master into feat-authz-custom

6d722b2

Merge branch 'origin/master' into feat-authz-custom

cb18f99

feat: generated authz endpoint api spec

17affc2

james-d-elliott marked this pull request as ready for review January 3, 2023 04:31

refactor: log server creation errors

c4e1382

james-d-elliott force-pushed the feat-authz-custom branch from 3d60177 to c4e1382 Compare January 3, 2023 05:01

james-d-elliott added 2 commits January 3, 2023 16:23

test: test templates can be parsed

87ce10e

docs: fix endpoint description

7fba9d4

james-d-elliott force-pushed the feat-authz-custom branch from d2f80d2 to 7fba9d4 Compare January 3, 2023 05:34

james-d-elliott added 2 commits January 3, 2023 17:10

Merge remote branch 'origin/master' into feat-authz-custom

cf2cf5b

fix: lint

c2c200c

james-d-elliott added 2 commits January 3, 2023 17:56

docs: authorization endpoint separation

a38cf86

refactor: error text

b5ba2c6

james-d-elliott changed the title ~~feat(sever): customizable authz endpoints~~ feat(server): customizable authz endpoints Jan 3, 2023

james-d-elliott added 2 commits January 4, 2023 11:31

Merge branch 'master' into feat-authz-custom

dfbd1b2

test: add tests and update implementation misc

c44693b

autheliabot reviewed Jan 20, 2023

View reviewed changes

internal/handlers/handler_authz_impl_legacy_test.go Outdated Show resolved Hide resolved

test: final adjustments

cf69e44

james-d-elliott mentioned this pull request Jan 21, 2023

Removing necessary Hop-by-Hop headers for Authelia Basic Authorization caddyserver/caddy#5285

Closed

refactor: remove handler_verify.go

420f759

autheliabot reviewed Jan 22, 2023

View reviewed changes

internal/handlers/handler_authz_util.go Outdated Show resolved Hide resolved

autheliabot reviewed Jan 22, 2023

View reviewed changes

internal/handlers/handler_authz_util.go Outdated Show resolved Hide resolved

james-d-elliott added 2 commits January 22, 2023 13:00

refactor: adjust metrics

f500c3c

fix: lint issues and basic scheme parser

ce7e59a

james-d-elliott force-pushed the feat-authz-custom branch from f4ab524 to ce7e59a Compare January 22, 2023 02:43

james-d-elliott requested a review from nightah January 22, 2023 03:18

Merge origin/master into feat-authz-custom

11df08d

nightah requested changes Jan 23, 2023

View reviewed changes

james-d-elliott and others added 3 commits January 23, 2023 14:48

fix: misc docs fixes

a4d45b1

fix: misc docs fixes

0ca648a

refactor: apply suggestions from code review

5f43865

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

autheliabot reviewed Jan 23, 2023

View reviewed changes

james-d-elliott and others added 6 commits January 23, 2023 15:24

refactor: apply suggestions from code review

cfba005

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

refactor: apply suggestions from code review

e398524

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

test: fix assert usage

cf44bfa

test: fix assert usage

fa4835b

refactor: apply suggestions

06a7f6f

docs: adjust haproxy

6e1af22

james-d-elliott requested a review from nightah January 23, 2023 09:33

james-d-elliott added 2 commits January 23, 2023 20:45

refactor: factorize

3d8492f

nightah approved these changes Jan 25, 2023

View reviewed changes

Merge branch 'master' into feat-authz-custom

561c64d

james-d-elliott merged commit 65705a6 into master Jan 25, 2023

james-d-elliott deleted the feat-authz-custom branch January 25, 2023 09:36

aerz mentioned this pull request Apr 12, 2023

[BUG] Authelia headers don't allow to connect to some services linuxserver/docker-swag#363

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server): customizable authz endpoints #4296

feat(server): customizable authz endpoints #4296

james-d-elliott commented Oct 30, 2022 •

edited

authelia bot commented Oct 30, 2022

netlify bot commented Oct 30, 2022 •

edited

codecov bot commented Jan 3, 2023 •

edited

nightah left a comment

nightah Jan 23, 2023

james-d-elliott Jan 23, 2023

nightah left a comment

feat(server): customizable authz endpoints #4296

feat(server): customizable authz endpoints #4296

Conversation

james-d-elliott commented Oct 30, 2022 • edited

authelia bot commented Oct 30, 2022

Artifacts

Docker Container

netlify bot commented Oct 30, 2022 • edited

✅ Deploy Preview for authelia-staging ready!

codecov bot commented Jan 3, 2023 • edited

Codecov Report

nightah left a comment

Choose a reason for hiding this comment

nightah Jan 23, 2023

Choose a reason for hiding this comment

james-d-elliott Jan 23, 2023

Choose a reason for hiding this comment

nightah left a comment

Choose a reason for hiding this comment

james-d-elliott commented Oct 30, 2022 •

edited

netlify bot commented Oct 30, 2022 •

edited

codecov bot commented Jan 3, 2023 •

edited