Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): ldap time replacements #4483

Merged
merged 7 commits into from
Dec 21, 2022

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Dec 6, 2022

This adds and utilizes several time replacements for both specialized LDAP implementations.

Closes #1964, Closes #1284

This adds a FreeIPA LDAP implementation which purely adds sane defaults for FreeIPA. There are no functional differences just when the implementation option is set to 'freeipa' sane defaults which should be sufficient for most use cases are set. See the documentation at https://www.authelia.com/r/ldap#defaults for more details.
This adds and utilizes several time replacements for both specialized LDAP implementations.
@authelia
Copy link

authelia bot commented Dec 6, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-ldap-datetime
  • docker pull ghcr.io/authelia/authelia:feat-ldap-datetime

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 66c2d2f
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63a2dc7c78f9d300089a1688
😎 Deploy Preview https://deploy-preview-4483--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #4483 (66c2d2f) into master (d0d80b4) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4483      +/-   ##
==========================================
- Coverage   68.05%   68.02%   -0.03%     
==========================================
  Files         268      268              
  Lines       18562    18589      +27     
  Branches      431      431              
==========================================
+ Hits        12633    12646      +13     
- Misses       5173     5184      +11     
- Partials      756      759       +3     
Flag Coverage Δ
backend 68.58% <63.63%> (-0.04%) ⬇️
frontend 62.21% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/utils/clock.go 20.00% <0.00%> (-30.00%) ⬇️
...ernal/authentication/ldap_user_provider_startup.go 93.44% <66.66%> (-2.14%) ⬇️
internal/authentication/ldap_user_provider.go 91.37% <81.25%> (-1.43%) ⬇️
internal/utils/time.go 87.23% <100.00%> (+0.56%) ⬆️
web/src/services/SignOut.ts 100.00% <0.00%> (+14.28%) ⬆️

# Conflicts:
#	docs/content/en/reference/guides/ldap.md
#	internal/configuration/schema/authentication.go
@james-d-elliott james-d-elliott merged commit d67554a into master Dec 21, 2022
@james-d-elliott james-d-elliott deleted the feat-ldap-datetime branch December 21, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldap: date time restriction Support for password expiration
2 participants