Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): file filters #4515

Merged
merged 14 commits into from
Dec 21, 2022
Merged

Conversation

james-d-elliott
Copy link
Member

This adds experimental file filters which are not guaranteed under our stability policies.

This adds experimental file filters which are not guaranteed under our stability policies.
@authelia
Copy link

authelia bot commented Dec 8, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-config-pre-processor
  • docker pull ghcr.io/authelia/authelia:feat-config-pre-processor

Copy link
Collaborator

@autheliabot autheliabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

yamllint

internal/configuration/test_resources/config.filtered.yml|44 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|45 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|46 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|47 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|48 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|49 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|61 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|65 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|70 col 13| [warning] comment not indented like content (comments-indentation)
internal/configuration/test_resources/config.filtered.yml|72 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|76 col 33| [error] syntax error: expected ',' or ']', but got '{' (syntax)
internal/configuration/test_resources/config.filtered.yml|76 col 53| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|76 col 70| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|76 col 88| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|90 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|97 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|104 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|111 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|121 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|126 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|129 col 15| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|129 col 33| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|131 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|134 col 13| [error] wrong indentation: expected 10 but found 12 (indentation)
internal/configuration/test_resources/config.filtered.yml|137 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|142 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|143 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|143 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|143 col 39| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|149 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|150 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|151 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|151 col 39| [error] too many spaces inside braces (braces)

internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #4515 (a467eae) into master (566a0d7) will decrease coverage by 0.08%.
The diff coverage is 60.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4515      +/-   ##
==========================================
- Coverage   68.21%   68.12%   -0.09%     
==========================================
  Files         266      268       +2     
  Lines       18373    18560     +187     
  Branches      431      431              
==========================================
+ Hits        12533    12644     +111     
- Misses       5095     5161      +66     
- Partials      745      755      +10     
Flag Coverage Δ
backend 68.63% <60.50%> (-0.11%) ⬇️
frontend 62.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/templates/funcs.go 2.22% <2.22%> (ø)
internal/commands/configuration.go 59.21% <62.50%> (-2.92%) ⬇️
...rnal/configuration/koanf_provider_filtered_file.go 77.00% <77.00%> (ø)
internal/configuration/sources.go 85.82% <81.25%> (-2.06%) ⬇️
internal/commands/crypto_hash.go 75.76% <100.00%> (+0.12%) ⬆️
internal/commands/root.go 39.82% <100.00%> (+0.52%) ⬆️
internal/commands/validate.go 71.69% <100.00%> (ø)
internal/configuration/template.go 100.00% <100.00%> (ø)
internal/server/handlers.go 92.85% <0.00%> (+1.07%) ⬆️

Copy link
Collaborator

@autheliabot autheliabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

yamllint

internal/configuration/test_resources/config.filtered.yml|150 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|151 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|151 col 39| [error] too many spaces inside braces (braces)

internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
internal/configuration/test_resources/config.filtered.yml Outdated Show resolved Hide resolved
@james-d-elliott james-d-elliott marked this pull request as ready for review December 21, 2022 04:10
@netlify
Copy link

netlify bot commented Dec 21, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit a467eae
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63a2ce3bfde8d90008eb0b08
😎 Deploy Preview https://deploy-preview-4515--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott merged commit c7f4d59 into master Dec 21, 2022
@james-d-elliott james-d-elliott deleted the feat-config-pre-processor branch December 21, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants