-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configuration): file filters #4515
Conversation
This adds experimental file filters which are not guaranteed under our stability policies.
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
yamllint
internal/configuration/test_resources/config.filtered.yml|44 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|45 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|46 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|47 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|48 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|49 col 17| [error] wrong indentation: expected 14 but found 16 (indentation)
internal/configuration/test_resources/config.filtered.yml|61 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|65 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|70 col 13| [warning] comment not indented like content (comments-indentation)
internal/configuration/test_resources/config.filtered.yml|72 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|76 col 33| [error] syntax error: expected ',' or ']', but got '{' (syntax)
internal/configuration/test_resources/config.filtered.yml|76 col 53| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|76 col 70| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|76 col 88| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|90 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|97 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|104 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|111 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|121 col 15| [error] wrong indentation: expected 12 but found 14 (indentation)
internal/configuration/test_resources/config.filtered.yml|126 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|129 col 15| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|129 col 33| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|131 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|134 col 13| [error] wrong indentation: expected 10 but found 12 (indentation)
internal/configuration/test_resources/config.filtered.yml|137 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|142 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|143 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|143 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|143 col 39| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|149 col 5| [error] wrong indentation: expected 2 but found 4 (indentation)
internal/configuration/test_resources/config.filtered.yml|150 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|151 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|151 col 39| [error] too many spaces inside braces (braces)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4515 +/- ##
==========================================
- Coverage 68.21% 68.12% -0.09%
==========================================
Files 266 268 +2
Lines 18373 18560 +187
Branches 431 431
==========================================
+ Hits 12533 12644 +111
- Misses 5095 5161 +66
- Partials 745 755 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
yamllint
internal/configuration/test_resources/config.filtered.yml|150 col 9| [error] wrong indentation: expected 6 but found 8 (indentation)
internal/configuration/test_resources/config.filtered.yml|151 col 17| [error] too many spaces inside braces (braces)
internal/configuration/test_resources/config.filtered.yml|151 col 39| [error] too many spaces inside braces (braces)
2ab9c84
to
0bfaabc
Compare
dd46d8a
to
6d9e058
Compare
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5124912
to
90e5f74
Compare
This adds experimental file filters which are not guaranteed under our stability policies.