Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): load config from directory #4616

Merged
merged 10 commits into from
Dec 22, 2022

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Dec 22, 2022

This allows specifying paths to a combination of files and directories with the --config option provided none of the specified file paths reside directly inside one of the specified directory paths. The directory paths are not recursive, and load .yml and .yaml files at this time.

@authelia
Copy link

authelia bot commented Dec 22, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-config-directory
  • docker pull ghcr.io/authelia/authelia:feat-config-directory

@james-d-elliott james-d-elliott changed the title feat(configuration): load from dir of files feat(configuration): load files from directory Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #4616 (2479179) into master (2eb8200) will decrease coverage by 0.00%.
The diff coverage is 67.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4616      +/-   ##
==========================================
- Coverage   67.83%   67.82%   -0.01%     
==========================================
  Files         268      268              
  Lines       18553    18654     +101     
  Branches      431      431              
==========================================
+ Hits        12585    12652      +67     
- Misses       5221     5252      +31     
- Partials      747      750       +3     
Flag Coverage Δ
backend 68.29% <67.09%> (-0.02%) ⬇️
frontend 62.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/commands/context.go 65.67% <33.33%> (+0.06%) ⬆️
internal/configuration/sources.go 79.73% <64.44%> (-6.20%) ⬇️
internal/commands/util.go 35.00% <70.65%> (+19.52%) ⬆️
internal/commands/root.go 41.35% <100.00%> (+1.00%) ⬆️
internal/configuration/template.go 90.00% <0.00%> (-10.00%) ⬇️

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 2479179
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63a3f5c4e16fd9000a8a9a7a
😎 Deploy Preview https://deploy-preview-4616--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

internal/commands/util.go Outdated Show resolved Hide resolved
internal/commands/util.go Outdated Show resolved Hide resolved
internal/commands/util.go Show resolved Hide resolved
internal/commands/util.go Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
internal/commands/util_test.go Outdated Show resolved Hide resolved
@james-d-elliott james-d-elliott changed the title feat(configuration): load files from directory feat(configuration): load config from directory Dec 22, 2022
@james-d-elliott james-d-elliott merged commit cc1e58e into master Dec 22, 2022
@james-d-elliott james-d-elliott deleted the feat-config-directory branch December 22, 2022 06:34
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Jan 7, 2023
@james-d-elliott james-d-elliott added the area/config Configuration related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Configuration related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants