Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): per-client pkce enforcement policy #4692

Merged
merged 7 commits into from
Jan 3, 2023

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Jan 3, 2023

This implements a per-client PKCE enforcement policy with the ability to enforce that it's used, and the specific challenge mode.

@authelia
Copy link

authelia bot commented Jan 3, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-oidc-per-client-pkce
  • docker pull ghcr.io/authelia/authelia:feat-oidc-per-client-pkce

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 300db81
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63b4370d6974f70008140b16
😎 Deploy Preview https://deploy-preview-4692--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #4692 (7b38f84) into master (1e86cb9) will increase coverage by 0.02%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4692      +/-   ##
==========================================
+ Coverage   67.41%   67.43%   +0.02%     
==========================================
  Files         266      266              
  Lines       19333    19367      +34     
  Branches      431      431              
==========================================
+ Hits        13034    13061      +27     
- Misses       5543     5550       +7     
  Partials      756      756              
Flag Coverage Δ
backend 67.84% <75.00%> (+0.01%) ⬆️
frontend 62.65% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/handler_oidc_authorization.go 42.52% <0.00%> (-4.91%) ⬇️
internal/oidc/types.go 91.78% <ø> (ø)
...rnal/configuration/validator/identity_providers.go 98.77% <100.00%> (+0.02%) ⬆️
internal/oidc/client.go 100.00% <100.00%> (ø)
internal/ntp/util.go 88.46% <0.00%> (+3.84%) ⬆️
web/src/services/SignOut.ts 100.00% <0.00%> (+14.28%) ⬆️

internal/oidc/client.go Outdated Show resolved Hide resolved
internal/oidc/client.go Outdated Show resolved Hide resolved
@james-d-elliott james-d-elliott merged commit adaf069 into master Jan 3, 2023
@james-d-elliott james-d-elliott deleted the feat-oidc-per-client-pkce branch January 3, 2023 15:03
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Jan 7, 2023
@james-d-elliott james-d-elliott added the area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants