Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): rfc2307bis implementation #4900

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Feb 8, 2023

This adds configuration defaults for RFC2307bis LDAP implementations such as OpenLDAP with the RFC2307bis LDIF which should service most user needs.

@authelia
Copy link

authelia bot commented Feb 8, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-ldap-rfc2307bis
  • docker pull ghcr.io/authelia/authelia:feat-ldap-rfc2307bis

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit b167fda
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63e307ae213db8000836afb1
😎 Deploy Preview https://deploy-preview-4900--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott force-pushed the feat-ldap-rfc2307bis branch 2 times, most recently from 0ba3505 to aa2a325 Compare February 8, 2023 02:06
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #4900 (aa2a325) into master (ba89200) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head aa2a325 differs from pull request most recent head b167fda. Consider uploading reports for the commit b167fda to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4900      +/-   ##
==========================================
+ Coverage   67.60%   67.71%   +0.10%     
==========================================
  Files         282      282              
  Lines       20695    20701       +6     
  Branches      443      443              
==========================================
+ Hits        13991    14017      +26     
+ Misses       5893     5872      -21     
- Partials      811      812       +1     
Flag Coverage Δ
backend 68.07% <100.00%> (+0.12%) ⬆️
frontend 63.15% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/configuration/validator/authentication.go 100.00% <100.00%> (ø)
web/src/services/SignOut.ts 85.71% <0.00%> (-14.29%) ⬇️
internal/server/handlers.go 92.76% <0.00%> (+6.60%) ⬆️

This adds configuration defaults for RFC2307bis LDAP implementations such as OpenLDAP with the RFC2307bis LDIF which should service most user needs.
@james-d-elliott james-d-elliott enabled auto-merge (squash) February 8, 2023 02:34
@james-d-elliott james-d-elliott merged commit 2e6d17b into master Feb 8, 2023
@james-d-elliott james-d-elliott deleted the feat-ldap-rfc2307bis branch February 8, 2023 02:35
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 2, 2023
@james-d-elliott james-d-elliott added area/config Configuration related features/bugs area/ldap LDAP related features/bugs labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Configuration related features/bugs area/ldap LDAP related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants