Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): client_secret_jwt client auth #5031

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

james-d-elliott
Copy link
Member

This theoretically adds support for client_secret_jwt.

@authelia
Copy link

authelia bot commented Mar 6, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-oidc-client-auth-secret-jwt
  • docker pull ghcr.io/authelia/authelia:feat-oidc-client-auth-secret-jwt

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit e6af718
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/6405486f6507270008a411da
😎 Deploy Preview https://deploy-preview-5031--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott force-pushed the feat-oidc-client-auth-secret-jwt branch from 6521519 to 17e1949 Compare March 6, 2023 00:12
This theoretically adds support for client_secret_jwt.
@james-d-elliott james-d-elliott force-pushed the feat-oidc-client-auth-secret-jwt branch from 17e1949 to 8fb9a00 Compare March 6, 2023 00:20
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #5031 (c739a23) into master (9c84fa5) will decrease coverage by 0.13%.
The diff coverage is 69.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5031      +/-   ##
==========================================
- Coverage   68.53%   68.41%   -0.13%     
==========================================
  Files         283      283              
  Lines       20964    20982      +18     
  Branches      443      443              
==========================================
- Hits        14367    14354      -13     
- Misses       5821     5853      +32     
+ Partials      776      775       -1     
Flag Coverage Δ
backend 68.84% <69.23%> (-0.14%) ⬇️
frontend 63.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/oidc/config.go 73.89% <0.00%> (-2.06%) ⬇️
internal/oidc/types.go 91.78% <ø> (ø)
internal/oidc/discovery.go 97.87% <100.00%> (+0.25%) ⬆️
internal/server/handlers.go 87.09% <0.00%> (-6.16%) ⬇️
internal/regulation/regulator.go 94.00% <0.00%> (-6.00%) ⬇️
internal/storage/sql_provider.go 47.40% <0.00%> (-0.34%) ⬇️
internal/session/provider.go 73.52% <0.00%> (+8.82%) ⬆️

@james-d-elliott james-d-elliott merged commit 42671d3 into master Mar 6, 2023
@james-d-elliott james-d-elliott deleted the feat-oidc-client-auth-secret-jwt branch March 6, 2023 02:36
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 2, 2023
@james-d-elliott james-d-elliott added the area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant