-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(handlers): authz authrequest authelia url #5181
Conversation
This returns a location header for the updated NGINX implementation allowing users to utilize the correct URL as determined by Authelia. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5181 +/- ##
==========================================
+ Coverage 68.01% 68.10% +0.08%
==========================================
Files 283 283
Lines 21230 21269 +39
Branches 443 443
==========================================
+ Hits 14440 14485 +45
+ Misses 6016 6013 -3
+ Partials 774 771 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
f88469e
to
650882f
Compare
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
1735bb7
to
cbe1c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small nits and considerations, WDYT?
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
# Conflicts: # docs/content/en/integration/proxies/caddy.md # docs/content/en/integration/proxies/envoy.md # docs/content/en/integration/proxies/haproxy.md # docs/content/en/integration/proxies/nginx.md # docs/content/en/integration/proxies/traefikv1.md
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
7e94e8e
to
b503f6c
Compare
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
cd76af6
to
b573c80
Compare
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
internal/server/template_test.go
Outdated
"os" | ||
"testing" | ||
|
||
"github.com/authelia/authelia/v4/internal/session" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not goimports
-ed with -local github.com/authelia/authelia (goimports)
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
8d117be
to
bc4e485
Compare
This adjusts the AuthRequest Authz implementation behave similarly to the other implementations in as much as Authelia can return the relevant redirection to the proxy and the proxy just utilizes it if possible. In addition it swaps the HAProxy examples over to the ForwardAuth implementation as that's now supported.