Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): postgresql webauthn tbl invalid aaguid constraint #5183

Merged
merged 6 commits into from Apr 8, 2023

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Apr 6, 2023

This fixes an issue with the PostgreSQL schema where the webauthn tables aaguid column had a NOT NULL constraint erroneously.

Fixes #5182

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@authelia
Copy link

authelia bot commented Apr 6, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:fix-not-null
  • docker pull ghcr.io/authelia/authelia:fix-not-null

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #5183 (da7f79d) into master (a40baee) will increase coverage by 0.09%.
The diff coverage is 78.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5183      +/-   ##
==========================================
+ Coverage   67.93%   68.02%   +0.09%     
==========================================
  Files         283      283              
  Lines       21209    21230      +21     
  Branches      443      443              
==========================================
+ Hits        14408    14442      +34     
+ Misses       6024     6014      -10     
+ Partials      777      774       -3     
Flag Coverage Δ
backend 68.41% <78.43%> (+0.10%) ⬆️
frontend 63.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/storage/sql_provider_schema.go 54.58% <33.33%> (+0.18%) ⬆️
internal/storage/migrations.go 79.84% <87.50%> (+14.98%) ⬆️
internal/model/schema_migration.go 100.00% <100.00%> (ø)

@james-d-elliott james-d-elliott changed the title fix(storage): migration issues fix(storage): postgresql webauthn tbl invalid aaguid constraint Apr 6, 2023
@netlify
Copy link

netlify bot commented Apr 8, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 016f85e
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/6430af24e86a520008798d0b
😎 Deploy Preview https://deploy-preview-5183--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott added the status/needs-review Pull requests that need to be reviewed label Apr 8, 2023
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@james-d-elliott james-d-elliott merged commit fa250ea into master Apr 8, 2023
49 checks passed
@james-d-elliott james-d-elliott deleted the fix-not-null branch April 8, 2023 01:36
@james-d-elliott james-d-elliott removed the status/needs-review Pull requests that need to be reviewed label Apr 8, 2023
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 2, 2023
@james-d-elliott james-d-elliott added the area/webauthn WebAuthn related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webauthn WebAuthn related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrolling Yubikey 4 as WebAuthn security key is not possible
3 participants