Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): client secret jwt client auth #5253

Merged
merged 1 commit into from
May 14, 2023

Conversation

james-d-elliott
Copy link
Member

This adds the authentication machinery for the client_secret_jwt Default Client Authentication Strategy.

@authelia
Copy link

authelia bot commented Apr 15, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-client-auth-jwt-hs
  • docker pull ghcr.io/authelia/authelia:feat-client-auth-jwt-hs

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #5253 (d3ecfd0) into master (9e5c6ec) will decrease coverage by 0.73%.
The diff coverage is 14.18%.

❗ Current head d3ecfd0 differs from pull request most recent head f415b76. Consider uploading reports for the commit f415b76 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5253      +/-   ##
==========================================
- Coverage   67.59%   66.87%   -0.73%     
==========================================
  Files         278      279       +1     
  Lines       21479    21736     +257     
  Branches      438      438              
==========================================
+ Hits        14519    14536      +17     
- Misses       6165     6393     +228     
- Partials      795      807      +12     
Flag Coverage Δ
backend 67.74% <14.18%> (-0.78%) ⬇️
frontend 56.52% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/handler_oidc_userinfo.go 0.00% <0.00%> (ø)
internal/oidc/types.go 89.33% <0.00%> (-2.45%) ⬇️
internal/oidc/client_auth.go 3.79% <3.79%> (ø)
...rnal/configuration/validator/identity_providers.go 97.23% <82.60%> (-0.94%) ⬇️
internal/oidc/client.go 96.53% <100.00%> (+0.02%) ⬆️
internal/oidc/discovery.go 75.60% <100.00%> (+0.14%) ⬆️
internal/oidc/keys.go 67.67% <100.00%> (ø)
internal/oidc/provider.go 94.33% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

@netlify
Copy link

netlify bot commented Apr 15, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit c49c27c
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/64616f6ff544960008f05a8f
😎 Deploy Preview https://deploy-preview-5253--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott force-pushed the feat-client-auth-jwt-hs branch 2 times, most recently from 99ec286 to fc720df Compare April 19, 2023 02:41
@james-d-elliott james-d-elliott changed the title feat(oidc): client_secret_jwt authentication feat(oidc): client secret jwt client auth Apr 20, 2023
@james-d-elliott james-d-elliott force-pushed the feat-client-auth-jwt-hs branch 5 times, most recently from aea54c9 to fb5b7ff Compare May 8, 2023 03:57
This adds the authentication machinery for the client_secret_jwt Default Client Authentication Strategy.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@james-d-elliott james-d-elliott enabled auto-merge (squash) May 14, 2023 23:36
@james-d-elliott james-d-elliott merged commit 1dbfbc5 into master May 14, 2023
47 of 48 checks passed
@james-d-elliott james-d-elliott deleted the feat-client-auth-jwt-hs branch May 14, 2023 23:52
@james-d-elliott
Copy link
Member Author

Approved in #5280

@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 2, 2023
@james-d-elliott james-d-elliott added the area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants