-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add password policy visible feedback on password change #5714
Conversation
This PR implements #5048 Signed-off-by: mind-ar
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5714 +/- ##
==========================================
+ Coverage 72.56% 72.68% +0.11%
==========================================
Files 277 277
Lines 23073 23082 +9
Branches 438 443 +5
==========================================
+ Hits 16743 16776 +33
+ Misses 5596 5572 -24
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LGTM! Do you happen to have a screenshot? |
Hi @james-d-elliott here's an screenshot Let me know if any change is needed |
added coverage test to password meter Signed-off-by: mind-ar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR implements #5048