Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add password policy visible feedback on password change #5714

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

mind-ar
Copy link
Collaborator

@mind-ar mind-ar commented Jul 27, 2023

This PR implements #5048

This PR implements #5048

Signed-off-by: mind-ar
@authelia
Copy link

authelia bot commented Jul 27, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-5048
  • docker pull ghcr.io/authelia/authelia:feat-5048

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #5714 (f76c5f3) into master (672da1d) will increase coverage by 0.11%.
The diff coverage is 81.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5714      +/-   ##
==========================================
+ Coverage   72.56%   72.68%   +0.11%     
==========================================
  Files         277      277              
  Lines       23073    23082       +9     
  Branches      438      443       +5     
==========================================
+ Hits        16743    16776      +33     
+ Misses       5596     5572      -24     
  Partials      734      734              
Flag Coverage Δ
backend 73.82% <ø> (+<0.01%) ⬆️
frontend 58.33% <81.81%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/PasswordMeter.tsx 86.30% <81.81%> (+37.86%) ⬆️

... and 1 file with indirect coverage changes

@james-d-elliott
Copy link
Member

LGTM! Do you happen to have a screenshot?

@mind-ar
Copy link
Collaborator Author

mind-ar commented Aug 2, 2023

Hi @james-d-elliott here's an screenshot
image

Let me know if any change is needed

added coverage test to password meter

Signed-off-by: mind-ar
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 2, 2023
@james-d-elliott james-d-elliott merged commit b0746dc into master Aug 3, 2023
50 checks passed
@james-d-elliott james-d-elliott deleted the feat-5048 branch August 3, 2023 00:38
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott added the area/ui UI related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants