Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): per-client custom token lifespans #5741

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

james-d-elliott
Copy link
Member

This allows configuring custom lifespans for individual clients. The lifespans can be completely separate per-client, and be individually tuned for each particular token type and grant type.

Adds support for per client per grant per token lifespan configuration.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
…fespan

# Conflicts:
#	internal/configuration/schema/identity_providers.go
Adds support for per client per grant per token lifespan configuration.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@authelia
Copy link

authelia bot commented Aug 1, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-oidc-client-lifespan
  • docker pull ghcr.io/authelia/authelia:feat-oidc-client-lifespan

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit a4575bc
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/64c98dc02c5b2400082eae24
😎 Deploy Preview https://deploy-preview-5741--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #5741 (bf9b980) into master (fc75773) will increase coverage by 0.03%.
The diff coverage is 93.75%.

❗ Current head bf9b980 differs from pull request most recent head 5ab790d. Consider uploading reports for the commit 5ab790d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5741      +/-   ##
==========================================
+ Coverage   72.52%   72.56%   +0.03%     
==========================================
  Files         277      277              
  Lines       22980    23038      +58     
  Branches      438      438              
==========================================
+ Hits        16667    16718      +51     
- Misses       5580     5585       +5     
- Partials      733      735       +2     
Flag Coverage Δ
backend 73.82% <93.75%> (+0.03%) ⬆️
frontend 56.76% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/configuration/deprecation.go 100.00% <ø> (ø)
internal/oidc/types.go 100.00% <ø> (ø)
...rnal/configuration/validator/identity_providers.go 94.08% <78.26%> (-0.40%) ⬇️
internal/oidc/client.go 100.00% <100.00%> (ø)
internal/oidc/config.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Adds support for per client per grant per token lifespan configuration.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@james-d-elliott james-d-elliott enabled auto-merge (squash) August 1, 2023 23:49
@james-d-elliott james-d-elliott merged commit 788be59 into master Aug 1, 2023
47 checks passed
@james-d-elliott james-d-elliott deleted the feat-oidc-client-lifespan branch August 1, 2023 23:59
@james-d-elliott james-d-elliott modified the milestones: v4.39.0, v4.38.0 Aug 2, 2023
@james-d-elliott james-d-elliott added the area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant