Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): update default headers #5881

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

james-d-elliott
Copy link
Member

This updates the default headers for many endpoints per the OWASP best practices.

This updates the default headers for many endpoints per the OWASP best practices.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@authelia
Copy link

authelia bot commented Aug 20, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:refactor-owasp-headers-rec
  • docker pull ghcr.io/authelia/authelia:refactor-owasp-headers-rec

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit dc77efd
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/64e1dca547b8370008b2ecdc
😎 Deploy Preview https://deploy-preview-5881--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #5881 (704e696) into master (321a380) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 704e696 differs from pull request most recent head 4c56b71. Consider uploading reports for the commit 4c56b71 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5881      +/-   ##
==========================================
+ Coverage   73.00%   73.02%   +0.01%     
==========================================
  Files         280      280              
  Lines       23692    23704      +12     
  Branches      443      443              
==========================================
+ Hits        17297    17310      +13     
+ Misses       5651     5650       -1     
  Partials      744      744              
Flag Coverage Δ
backend 74.16% <100.00%> (+0.01%) ⬆️
frontend 58.33% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/middlewares/headers.go 92.30% <100.00%> (+1.13%) ⬆️
internal/server/asset.go 70.22% <100.00%> (+0.51%) ⬆️
internal/server/template.go 60.79% <100.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 96054c7
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/64e1e173048cdf000965eb12
😎 Deploy Preview https://deploy-preview-5881--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@james-d-elliott james-d-elliott force-pushed the refactor-owasp-headers-rec branch 2 times, most recently from 190340d to 96054c7 Compare August 20, 2023 09:48
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@james-d-elliott james-d-elliott enabled auto-merge (squash) August 20, 2023 09:56
@james-d-elliott james-d-elliott merged commit e9e2969 into master Aug 20, 2023
46 checks passed
@james-d-elliott james-d-elliott deleted the refactor-owasp-headers-rec branch August 20, 2023 09:58
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant