Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session): redirection by cookie domain #6017

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

james-d-elliott
Copy link
Member

This allows configuring the default redirection URL by session domain.

@authelia
Copy link

authelia bot commented Sep 20, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-redirection-by-domain
  • docker pull ghcr.io/authelia/authelia:feat-redirection-by-domain

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit de8f495
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/6515fd6617800500081c26a7
😎 Deploy Preview https://deploy-preview-6017--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@james-d-elliott james-d-elliott marked this pull request as ready for review September 28, 2023 11:42
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #6017 (de8f495) into master (1a96b5c) will increase coverage by 0.02%.
The diff coverage is 97.34%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6017      +/-   ##
==========================================
+ Coverage   74.40%   74.42%   +0.02%     
==========================================
  Files         286      286              
  Lines       25266    25324      +58     
  Branches      443      443              
==========================================
+ Hits        18798    18848      +50     
- Misses       5709     5721      +12     
+ Partials      759      755       -4     
Flag Coverage Δ
backend 75.59% <97.34%> (+0.02%) ⬆️
frontend 58.27% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/configuration/schema/types.go 81.46% <ø> (ø)
internal/configuration/validator/configuration.go 100.00% <100.00%> (ø)
internal/configuration/validator/session.go 100.00% <100.00%> (ø)
internal/handlers/handler_state.go 58.33% <100.00%> (+3.78%) ⬆️
internal/middlewares/authelia_context.go 78.87% <100.00%> (+1.91%) ⬆️
internal/utils/url.go 100.00% <100.00%> (ø)
internal/handlers/response.go 43.98% <75.00%> (+1.43%) ⬆️

... and 3 files with indirect coverage changes

@james-d-elliott james-d-elliott force-pushed the feat-redirection-by-domain branch 6 times, most recently from 8999293 to 976bbb3 Compare September 28, 2023 21:52
This allows configuring the default redirection URL by session domain.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@james-d-elliott james-d-elliott merged commit 6a6059d into master Sep 28, 2023
49 checks passed
@james-d-elliott james-d-elliott deleted the feat-redirection-by-domain branch September 28, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants