fix(server): invalid base url

[james-d-elliott]

This fixes an issue where the Base URL is not properly formed for the purposes of static asset acquisition.

Summary by CodeRabbit

• Refactor
  • Improved the logic for retrieving provider information and optimized the assignment of baseURL in server templates for enhanced performance.

[authelia]

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

• docker pull authelia/authelia:fix-server-path
• docker pull ghcr.io/authelia/authelia:fix-server-path

[coderabbitai]

Walkthrough

The update primarily focuses on enhancing the ServeTemplatedFile function within the server's template handling mechanism. This enhancement includes a strategic reassignment of the baseURL variable and a refined approach for retrieving the provider. These adjustments aim to optimize the function's execution flow and improve its interaction with external resources or settings, contributing to a more efficient and reliable template serving process.

Changes

File(s)	Summary of Changes
internal/server/template.go	Modified the ServeTemplatedFile function by reordering baseURL assignment and refining provider retrieval logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d9cb3ed and 487bd84.

Files selected for processing (1)

• internal/server/template.go (1 hunks)

Additional comments: 2

internal/server/template.go (2)

• 71-71: The reassignment of baseURL to ctx.RootURLSlash().String() is done before retrieving the session provider. This ensures that baseURL is set even if there's an error in getting the session provider, which is a good practice for ensuring that baseURL is always defined. However, it's important to verify that this reordering does not impact any logic that depends on the baseURL being set after the provider is retrieved.
• 73-73: Retrieving the session provider and setting domain and rememberMe based on the provider's configuration is crucial for the correct operation of templated files. This logic appears to be unchanged, but it's important to ensure that the provider's configuration is always correctly applied. If there are any known issues with the session provider retrieval or configuration application, they should be addressed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (9b788db) to head (487bd84).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6881      +/-   ##
==========================================
- Coverage   73.55%   73.55%   -0.01%     
==========================================
  Files         345      345              
  Lines       29508    29503       -5     
  Branches      839      839              
==========================================
- Hits        21706    21702       -4     
+ Misses       6944     6943       -1     
  Partials      858      858              

Flag	Coverage Δ
backend	74.45% <100.00%> (-0.01%)	⬇️
frontend	65.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
internal/server/template.go	61.90% <100.00%> (+1.47%)	⬆️

... and 2 files with indirect coverage changes