fix(oidc): form post csp not set correctly #7017

james-d-elliott · 2024-03-25T01:16:02Z

This fixes an issue where the Content Security Policy was not set correctly in all situations.

Summary by CodeRabbit

Bug Fixes
- Improved handling of OpenID Connect authorization requests by adjusting the sequence of response mode checks and user value settings.

This fixes an issue where the Content Security Policy was not set correctly in all situations.

authelia · 2024-03-25T01:16:06Z

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

docker pull authelia/authelia:fix-oidc-form-post
docker pull ghcr.io/authelia/authelia:fix-oidc-form-post

coderabbitai · 2024-03-25T01:16:19Z

Walkthrough

The recent update focuses on refining the process of handling OpenID Connect authorization requests. It involves reordering the operation sequence to ensure the FormPost response mode is checked promptly and adjusting when a user value based on the response mode is set. These modifications aim to enhance the accuracy and efficiency of response mode handling within the authorization flow.

Changes

File	Change Summary
`.../handler_oidc_authorization.go`	Moved the check for `FormPost` response mode before error handling and adjusted the timing for setting a user value based on the response mode.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov · 2024-03-25T01:16:53Z

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.40%. Comparing base (d835d55) to head (b6a0500).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7017      +/-   ##
==========================================
+ Coverage   73.36%   73.40%   +0.03%     
==========================================
  Files         345      345              
  Lines       29724    29726       +2     
  Branches      839      839              
==========================================
+ Hits        21808    21819      +11     
+ Misses       7045     7039       -6     
+ Partials      871      868       -3

Flag	Coverage Δ
backend	`74.27% <33.33%> (+0.03%)`	⬆️
frontend	`65.84% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
internal/handlers/handler_oidc_authorization.go	`30.43% <33.33%> (+1.02%)`	⬆️

... and 3 files with indirect coverage changes

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d835d55 and b6a0500.

Files selected for processing (1)

internal/handlers/handler_oidc_authorization.go (2 hunks)

coderabbitai · 2024-03-25T01:20:07Z

internal/handlers/handler_oidc_authorization.go

+	requester, err = ctx.Providers.OpenIDConnect.NewAuthorizeRequest(ctx, r)
+
+	if requester != nil && requester.GetResponseMode() == oidc.ResponseModeFormPost {
+		ctx.SetUserValue(middlewares.UserValueKeyOpenIDConnectResponseModeFormPost, true)
+	}


The adjustment to check for the FormPost response mode before proceeding with error handling is a logical improvement. It ensures that the CSP is set correctly by identifying the response mode early. However, it's noted that these lines were not covered by tests.

Consider adding unit tests to cover this new logic path to ensure it behaves as expected under various conditions.

fix(oidc): form post csp not set correctly

b6a0500

This fixes an issue where the Content Security Policy was not set correctly in all situations.

coderabbitai bot reviewed Mar 25, 2024

View reviewed changes

james-d-elliott merged commit 2ebc04f into master Mar 25, 2024
50 of 52 checks passed

james-d-elliott deleted the fix-oidc-form-post branch March 25, 2024 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(oidc): form post csp not set correctly #7017

fix(oidc): form post csp not set correctly #7017

james-d-elliott commented Mar 25, 2024 •

edited by coderabbitai bot

authelia bot commented Mar 25, 2024

coderabbitai bot commented Mar 25, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

codecov bot commented Mar 25, 2024 •

edited

coderabbitai bot left a comment

coderabbitai bot Mar 25, 2024

fix(oidc): form post csp not set correctly #7017

fix(oidc): form post csp not set correctly #7017

Conversation

james-d-elliott commented Mar 25, 2024 • edited by coderabbitai bot

Summary by CodeRabbit

authelia bot commented Mar 25, 2024

Artifacts

Docker Container

coderabbitai bot commented Mar 25, 2024 • edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

codecov bot commented Mar 25, 2024 • edited

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

james-d-elliott commented Mar 25, 2024 •

edited by coderabbitai bot

coderabbitai bot commented Mar 25, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Mar 25, 2024 •

edited