fix(commands): build-info too verbose #7128
Conversation
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
WalkthroughThe recent updates aim to enhance build information output and version management across various files. The introduction of the "verbose" flag in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (7)
Files skipped from review as they are similar to previous changes (3)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
james-d-elliott
force-pushed
the
fix-build-info-verbosity
branch
2 times, most recently
from
1d99b9b
to
2394309
Compare
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
internal/commands/build-info.go
Outdated
| } | ||
| } | ||
|
|
||
| _, err = fmt.Printf(fmtAutheliaBuild, utils.BuildTag, utils.BuildState, utils.BuildBranch, utils.BuildCommit, | ||
| utils.BuildNumber, runtime.GOOS, runtime.GOARCH, runtime.Compiler, utils.BuildDate, utils.BuildExtra, b.String()) | ||
| fmt.Printf(b.String()) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
james-d-elliott
force-pushed
the
fix-build-info-verbosity
branch
2 times, most recently
from
317dc61
to
e4a71cc
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
internal/commands/build-info.go
Outdated
| } | ||
| } | ||
|
|
||
| _, err = fmt.Printf(fmtAutheliaBuild, utils.BuildTag, utils.BuildState, utils.BuildBranch, utils.BuildCommit, | ||
| utils.BuildNumber, runtime.GOOS, runtime.GOARCH, runtime.Compiler, utils.BuildDate, utils.BuildExtra, b.String()) | ||
| fmt.Printf(b.String()) |
There was a problem hiding this comment.
Replace fmt.Printf with fmt.Print to avoid unnecessary formatting since no formatting arguments are provided.
- fmt.Printf(b.String())
+ fmt.Print(b.String())Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| fmt.Printf(b.String()) | |
| fmt.Print(b.String()) |
This fixes an issue where the build-info command is too verbose. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
james-d-elliott
force-pushed
the
fix-build-info-verbosity
branch
from
e4a71cc
to
62fd2e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7128 +/- ##
==========================================
+ Coverage 73.63% 73.69% +0.05%
==========================================
Files 344 344
Lines 29930 29937 +7
Branches 839 839
==========================================
+ Hits 22039 22062 +23
+ Misses 7019 7008 -11
+ Partials 872 867 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This fixes an issue where the build-info command is too verbose.