Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.0-beta3 #230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

v0.9.0-beta3 #230

wants to merge 3 commits into from

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Apr 19, 2024 •
edited by coderabbitai bot

This implements the following features:

  • Ensures if watch is true that the stateful value is false when using the file backend.

Fixes #168

Summary by CodeRabbit

  • New Features

    • Updated Authelia to version 0.9.0-beta3.
    • Added support for initializing containers in Authelia's deployment configuration.
    • Introduced a new configuration option hostNameOverride for ingress settings.

  • Documentation

    • Documented the new pod.initContainers parameter.

  • Refactor

    • Enhanced LDAP authentication checks.
    • Implemented a new template rendering function for improved customization.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 19, 2024 •
edited

Walkthrough

This update to the Authelia Helm chart introduces a new version of Authelia, adds support for initial containers, updates LDAP authentication logic, and introduces a new template rendering function. It also includes changes to support overriding host names in ingress configurations and modifies handling of replicas when local storage files are enabled.

Changes

Files Change Summary
charts/authelia/Chart.yaml Updated Authelia version from 0.9.0-beta2 to 0.9.0-beta3.
charts/authelia/README.md Updated the chart to include Bitnami subcharts for deploying redis, postgresql, and/or mariadb. Added new configurations for pod.initContainersand deployment options forredis, mariadb, and postgresql` to the chart values.
.../_helpers.tpl, .../values.yaml Updated logic for LDAP authentication checks. Introduced authelia.snippets.render template rendering function. Added an empty initContainers section in the pod configuration.
.../deployment.yaml Added support for initializing containers if pod.initContainers is specified.
.../values.local.yaml Added hostNameOverride field under ingress. Replaced initContainers block with an empty array.

Assessment against linked issues

Objective Addressed Explanation
Set replicas if local storage file enabled (#168) ❓ It's unclear if the handling of replicas when local storage files are enabled has been addressed. The provided summary does not mention changes related to scaling replicas based on the configuration of the local storage file. Further review of the actual code changes in _helpers.tpl would be necessary to confirm.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@james-d-elliott
fix: stateful true when watch enabled
94acdb2 
This ensures if watch is true that the stateful value is false when using the file backend.
@james-d-elliott james-d-elliott mentioned this pull request Apr 19, 2024
Closed
@hqdncw @james-d-elliott
feat: add support for custom initContainers
9fccf91 
Signed-off-by: uid54289 <120799552+uid54289@users.noreply.github.com>
@james-d-elliott james-d-elliott mentioned this pull request Apr 19, 2024
Closed
1 task
coderabbitai[bot]
coderabbitai bot reviewed Apr 28, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
.buildkite/hooks/pre-command (1)

Line range hint 12-19: Consider adding a safety check before using rm -rf to avoid accidental deletion of important data.

+ if [[ -d ".cr-release-packages" || -d ".cr-index" ]]; then
    rm -rf .cr-release-packages .cr-index
+ fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set replicas if local storage file enabled
2 participants
@james-d-elliott @hqdncw