Password reveal triggers keyboard on Android

[Turux]

Pressing inside the password field to reveal it opens the keyboard on Android.

I have the feeling this is not the right behaviour as it can result in accidental password edits.

Alternatively, would it be possible to ask for confirmation prior to a password edit?

[eL-Prova]

Similar experience on iOS, See #109

[hpoul]

@Turux @eL-Prova to be honest, for me displaying a password is a rare edge case.. since all my passwords are auto generated, there is no way i'd try to type them.. simply copy&paste them (swipe on the entry to either side of the screen to copy).. also did you try the 'Present' option from the dropdown? it shows you the password in pretty large letters as well as a QR code.

[eL-Prova]

@hpoul good case, but I work a lot on my computer, but keep my passwords on my phone. In this case I type my (generated) passwords from my phone to the computer for example :-)

[hpoul]

@eL-Prova got it, how about the 'present' option? that's basically why it's there :-) I guess it could still be improved, with even bigger font, and smaller QR code..

[Turux]

The "present" option can be useful, thanks for pointing it out!
I still believe that the current behaviour is wrong though. If the app states "Click to reveal" this can confuse the user, as instead it edits the field. Can I suggest to either change the behaviour or change the label to something like "Click to Edit"?

Also, OT, but the message is very hard to read.

[capruro]

I agree with @Turux the text "Click to reveal" is misleading, it's supposed to show the password only, not actually edit the password.
There are a lot of cases where you actually need to see the password, as I'm using keepass DB not only for browser password but also for PIN, application password where there is no copy-paste integration and other cases where I just want to save something not in clear text.

[hpoul]

i guess that makes sense.. i could also imagine simply replacing password entirely with just buttons like 'Reveal', 'Present' and 'Edit' ..
the idea was just that it would be cool if it "looks" like it's just hidden .. but it's faked anyway.. and even if there is no password, it would still look the same, which bothers me as well..

do you think it makes sense to have the difference between 'Reveal' and 'Present' (reveal would be inline, read only, vs. present the big font modal overlay)

[eL-Prova]

@hpoul I suggest to make it KIS, Keep It Simple. Edit by tapping so you make it an explicit action, hit the input shows the present view. In that case it is revealed. When editing your password will also be revealed.

[capruro]

I would suggest to have a readonly interface in the first place and then have an edit button to make changes (as mentioned in #108). It shouldn't be easy to make mistakes, also because I don't see a password history yet.

[hpoul]

Edit by tapping so you make it an explicit action, hit the input shows the present view.

i don't quite get the difference between editing and presenting in this case? Where do I have to tap for each?

@capruro yes, password history is written, but there is no UI for it yet (#92). I'm not sure about having an explicit "edit" mode, especially for normale fields, tapping into the field is already pretty intentional. but I agree with preventing mistakes - #91 is for improving the revert/discard workflow.

[capruro]

password history is written, but there is no UI for it yet (#92)

Good to know

I would prefer to have a read only mode where you can only see/copy the data and on password filed there should be "Click to reveal" and presenting on the corner.
Then an edit mode where you can tap to reveal and edit the password field and generate password on the corner.

[hpoul]

I move "read only" mode into a separate Issue #148 with a more descriptive title. Feel free to comment your suggestions about a read-only mode there as well. I'll close this issue.