Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The return type of signinCallback is not properly typed #1492

Closed
noshiro-pf opened this issue May 3, 2024 · 0 comments · Fixed by #1490
Closed

The return type of signinCallback is not properly typed #1492

noshiro-pf opened this issue May 3, 2024 · 0 comments · Fixed by #1490
Labels
bug Something isn't working

Comments

@noshiro-pf
Copy link
Contributor

noshiro-pf commented May 3, 2024 •
edited

The return type Promise<User | void> of signinCallback is not properly typed and should be Promise<User | undefined>.

Functions annotated with a void return type are created with the intention that their return value will not be used, so using the type User | void for the return value seems to be against that intention.

Related URLs
@noshiro-pf noshiro-pf mentioned this issue May 3, 2024
Merged
2 tasks
@pamapa pamapa added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the return type of signinCallback noshiro-pf/oidc-client-ts
2 participants
@pamapa @noshiro-pf